On 03/02/17 06:57, Hurugalawadi, Naveen wrote:
Hi Andrew,

Thanks for clearing the confusion.

I don't understand this comment and how it relates to your updated patch
foo, foo1 and foo2 generates calls to "popcountdi2" which should have
been "popcountsi2" for foo1. When Kyrill commented on using the
popcountsi2; I was confused :).

Hence, the testcase generally checks for the absence of call to "popcount"
and the presence of "cnt" instruction instead.


Sorry for the confusion, I should have been more explicit that I was talking
about the optab.

Now of course what should change still is the argument
types to foo1/foo2
The arguments to foo1 and foo2 are modified as required.

Bootstrapped and regression tested on aarch64-linux-gnu with no regressions.

Please let us know if its okay for stage 1?

This looks good to me, but you'll need James (or another aarch64 maintainer) to 
approve.

Thanks,
Kyrill

Thanks,
Naveen

Reply via email to