On 01/26/2017 01:04 PM, Thomas Preudhomme wrote: > Hi JonY, > > On 19/01/17 01:37, JonY wrote: >> On 01/18/2017 09:48 AM, Thomas Preudhomme wrote: >>> By default, wildcard support on Windows for programs compiled with mingw >>> depends on how the mingw runtime was configured. This means if one wants >>> to build GCC for Windows with a consistent behavior with Wildcard >>> (enabled or disabled) the mingw runtime must be built as well. This >>> patch adds an option to GCC configuration to force the behavior with >>> wildcard when building GCC for Windows host. It does so by setting the >>> _dowildcard variable in the driver to a given value depending on the >>> configure option value (yes or no), thus overriding the variable from >>> mingw runtime. >>> >>> Testing: I've successfully done a build of the arm-none-eabi cross GCC >>> for Windows with Ubuntu system mingw runtime (configured without >>> wildcard support by default) with the three configure options: >>> 1) --enable-wildcard: wildcard can be used successfully and nm of >>> driver-mingw32.o shows that _dowildcard is in .data section >>> 2) --disable-wildcard: wildcard cannot be used and nm of >>> driver-mingw32.o shows that _dowildcard is in .bss section >>> 3) no option: wildcard cannot be used and nm of driver-mingw32.o shows >>> no _dowildcard defined and all sections are empty >>> >>> Is this ok for stage1? >>>
Looks good, be sure to emphasize this option affects mingw hosted GCC only, not the compiler output.
signature.asc
Description: OpenPGP digital signature
