On Mon, 27 Feb 2017, Jakub Jelinek wrote: > On Mon, Feb 27, 2017 at 11:04:36AM +0100, Volker Reichelt wrote: > > > This is not -Wformat-security friendly, perhaps better > > > pedwarn (EXPR_LOC_OR_LOC (outer_nelts, input_location), OPT_Wvla, > > > typedef_variant_p (orig_type) > > > ? "non-constant array new length must be specified " > > > "directly, not by typedef" > > > : "non-constant array new length must be specified " > > > "without parentheses around the type-id"); > > > ? > > > > Not quite. Like this the second string doesn't end up in the gcc.pot > > file for translation. I had to wrap the second string in G_(...) to make > > it work. (I'll have a look for other instances of this pattern and > > prepare a separate patch.) > > Looks like a xgettext bug or missing feature :(. Joseph, shall we just > change all those to be G_() around the second string (well, some could be
Yes, it's generally the case that G_() is used whenever there's a conditional expression for the msgid argument to a diagnostic function. -- Joseph S. Myers jos...@codesourcery.com
