On 03/08/2017 08:29 AM, Mark Wielaard wrote:
On Wed, 2017-03-08 at 08:22 -0500, Nathan Sidwell wrote:
https://gcc.gnu.org/ml/gcc-patches/2017-03/msg00089.html?
Patch looks good to me (not a libiberty maintainer)
One question:
+ if (dc == NULL || dc->d_printing > 1)
Can dc ever be null here, or is this just extra defensiveness?
Yes, dc can be NULL. There is a similar check (and setting of
d_print_error) in d_print_comp_inner.
thanks. in case you'd not noticed Ian T's okayed my review. so this is
good to go
nathan
--
Nathan Sidwell
