Hi, The gcc.dg/pic-2.c and gcc.dg/pie-2.c tests are failing for MIPS targets because __PIC__ is always set to 1 for MIPS.
This patch makes the testsuite skip those two tests for all MIPS targets. Tested with mips-mti-elf and mips-mti-linux-gnu. Should I have fixed this in target-supports.exp instead ? I was worried that doing so would complicate the fpic and pie effective target checks too much. Regards, Toma gcc/testsuite/ * gcc.dg/pic-2.c: Skip for MIPS. * gcc.dg/pie-2.c: Skip for MIPS. diff --git a/gcc/testsuite/gcc.dg/pic-2.c b/gcc/testsuite/gcc.dg/pic-2.c index 59ce8e2..bccec13 100644 --- a/gcc/testsuite/gcc.dg/pic-2.c +++ b/gcc/testsuite/gcc.dg/pic-2.c @@ -1,6 +1,7 @@ /* { dg-do compile } */ /* { dg-require-effective-target fpic } */ /* { dg-options "-fPIC" } */ +/* { dg-skip-if "__PIC__ is always 1 for MIPS" { mips*-*-* } } */ #if __PIC__ != 2 # error __PIC__ is not 2! diff --git a/gcc/testsuite/gcc.dg/pie-2.c b/gcc/testsuite/gcc.dg/pie-2.c index 7bdc4ac..1838745 100644 --- a/gcc/testsuite/gcc.dg/pie-2.c +++ b/gcc/testsuite/gcc.dg/pie-2.c @@ -1,6 +1,7 @@ /* { dg-do compile } */ /* { dg-options "-fPIE" } */ /* { dg-require-effective-target pie } */ +/* { dg-skip-if "__PIC__ is always 1 for MIPS" { mips*-*-* } } */ #if __PIC__ != 2 # error __PIC__ is not 2!