On 17/03/17 12:22, Kyrill Tkachov wrote: > Hi Sudi, > > On 16/03/17 11:11, Sudi Das wrote: >> >> Hi all >> >> This is a cleanup patch to remove the macro TARGET_EITHER. This macro >> seems to have become irrelevant in recent times since its previous >> definition had been commented out and replaced with 1. >> >> Bootstrapped and tested on arm-none-linux-gnueabihf. >> > > I've had my eye on that cleanup for some time now, thanks for doing this. > This patch is ok. > Seeing as we're close to the GCC 7 release and this is not a regression fix > I'd rather hold off applying it until after the release, so I've put > this in > my queue of things to commit then. > > Thanks, > Kyrill > >> Sudi >> >> 2017-03-10 Sudakshina Das <sudi....@arm.com> >> >> * config/arm/arm.h (TARGET_EITHER): Delete. >> * config/arm/arm.md: Delete instances of TARGET_EITHER. >
The point of TARGET_EITHER was mostly to document that the operation was deliberately enabled in all compilation modes and that leaving out a choice of TARGET32 vs Thumb1 was not accidental. As such, it's more documentation than necessary code. Does this really affect the performance/behaviour of the compiler? If it doesn't then I'd be in favour of leaving it as is. R.