Ping.

https://gcc.gnu.org/ml/gcc-patches/2017-03/msg01271.html

Thanks,
Kyrill

On 24/03/17 11:14, Kyrill Tkachov wrote:
Hi all,

This PR complains that the bounds checking error strings contain a string placeholder for 
"constant" or "lane"
which makes it hard for translators (who may want to move words around in a 
different language for syntactical reasons).

This patch cleans that up. The bunching up of common functionality between 
neon_lane_bounds and arm_const_bounds was a bit
dubious in any case as arm_const_bounds never passed down a non-NULL tree 
anyway, so one of the paths of bonds_check was
always used in only the neon_lane_bounds case anyway.

I also add some function comments and use IN_RANGE for range checking.
Bootstrapped and tested on arm-none-linux-gnueabihf.

Ok for trunk? (I believe such translation improvements fall under the 
documentation rule at this stage).

Thanks,
Kyrill

2017-03-24  Kyrylo Tkachov  <kyrylo.tkac...@arm.com>

    PR target/79871
    * config/arm/arm.c (bounds_check): Delete.
    (neon_lane_bounds): Adjust.  Make sure error string template
    doesn't use string placeholder.
    (arm_const_bounds): Likewise.

Reply via email to