On 04/14/2017 02:48 PM, Nathan Sidwell wrote:
On 04/14/2017 08:45 AM, Martin Liška wrote:
Hello.
Patch handles ICE when gcov-tool either merges or scales gcov files and
destination folder (where all files are merged) is non-empty.
Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
And gcov.exp works on x86_64-linux-gnu.
Ok. Perhaps change the message from:
fatal_error (input_location, "Output file %s should be removed "
+ "in destination folder: %s", filename, out);
Thanks, I'll change that.
to 'output file %s already exists in folder %s' or something? I.e report what
the problem is, not what the solution might be -- after all, if the only
solution is to delete the output file, why isn't gcov-tool doing that?
It's doing that on targets that have nftw:
static int
unlink_profile_dir (const char *path ATTRIBUTE_UNUSED)
{
#if HAVE_FTW_H
return nftw(path, unlink_gcda_file, 64, FTW_DEPTH | FTW_PHYS);
#else
return -1;
#endif
}
Martin
nathan
