On Fri, Apr 07, 2017 at 05:08:55PM +0200, Thomas Schwinge wrote:
> Hi!
>
> OpenACC 2.5 added a default (present) clause, which "causes all arrays or
> variables of aggregate data type used in the compute construct that have
> implicitly determined data attributes to be treated as if they appeared
> in a present clause". Preceded by the following cleanup patch (see
> <https://gcc.gnu.org/ml/gcc-patches/2017-04/msg00377.html> for its
> origin), OK for trunk in next stage 1?
>
> commit 787fea9e71f693c1b629a699f8476f392c4bc55d
> Author: Thomas Schwinge <tho...@codesourcery.com>
> Date: Thu Apr 6 07:58:37 2017 +0200
>
> Clarify gcc/gimplify.c:oacc_default_clause
>
> gcc/
> * gimplify.c (oacc_default_clause): Clarify.
> ---
> gcc/gimplify.c | 40 ++++++++++++++++++++++------------------
> 1 file changed, 22 insertions(+), 18 deletions(-)
>
> @@ -6897,6 +6900,7 @@ omp_default_clause (struct gimplify_omp_ctx *ctx, tree
> decl,
> found_outer:
> break;
>
> + case OMP_CLAUSE_DEFAULT_PRESENT:
> default:
> gcc_unreachable ();
> }
What is the point of this hunk? Document that present clause is not in
OpenMP? I don't think that is needed.
> + case 0 | GOVD_MAP_FORCE:
> + kind = GOMP_MAP_TOFROM | GOMP_MAP_FLAG_FORCE;
> + break;
Please drop the "0 | ".
> @@ -357,7 +357,9 @@ enum omp_clause_code {
> /* OpenMP clause: ordered [(constant-integer-expression)]. */
> OMP_CLAUSE_ORDERED,
>
> - /* OpenMP clause: default. */
> + /* OpenACC clause: default ( none | present ).
> +
> + OpenMP clause: default ( firstprivate | none | private | shared ). */
> OMP_CLAUSE_DEFAULT,
>
> /* OpenACC/OpenMP clause: collapse (constant-integer-expression). */
I think this hunk isn't needed (plus it is not accurate anyway).
Otherwise LGTM.
Jakub
