Hi Nathan,

> On 05/08/2017 05:34 PM, Joseph Myers wrote:
>> On Mon, 8 May 2017, Nathan Sidwell wrote:
>
>>> This patch changes the C++ FE to override the pushdecl and getdecl lang
>>> hooks.
>>> In addition to simply overriding them there, I had to fixup a couple of
>>> places
>>> in c-family/c-common.c and objc/objc-gnu-runtime-abi-01.c to use the 
>>> pushdecl
>>> hook.
>>
>> The c/ and c-family/ changes are OK.
>
> Thanks.  I've taken the objc change as therefore obvious and committed
> (with the formatting fix Marek pointed out).

however, it breaks bootstrap with --enable-languages=obj-c++:

In file included from /vol/gcc/src/hg/trunk/local/gcc/objcp/objcp-lang.c:28:0:
/vol/gcc/src/hg/trunk/local/gcc/langhooks-def.h:227:29: error: 'getdecls' was 
not declared in this scope
 #define LANG_HOOKS_GETDECLS getdecls
                             ^
/vol/gcc/src/hg/trunk/local/gcc/langhooks-def.h:249:3: note: in expansion of 
macro 'LANG_HOOKS_GETDECLS'
   LANG_HOOKS_GETDECLS, \
   ^~~~~~~~~~~~~~~~~~~
/vol/gcc/src/hg/trunk/local/gcc/langhooks-def.h:323:3: note: in expansion of 
macro 'LANG_HOOKS_DECLS'
   LANG_HOOKS_DECLS, \
   ^~~~~~~~~~~~~~~~
/vol/gcc/src/hg/trunk/local/gcc/objcp/objcp-lang.c:47:32: note: in expansion of 
macro 'LANG_HOOKS_INITIALIZER'
 struct lang_hooks lang_hooks = LANG_HOOKS_INITIALIZER;
                                ^~~~~~~~~~~~~~~~~~~~~~
/vol/gcc/src/hg/trunk/local/gcc/langhooks-def.h:227:29: note: suggested 
alternative: 'getdelim'
 #define LANG_HOOKS_GETDECLS getdecls
                             ^
/vol/gcc/src/hg/trunk/local/gcc/langhooks-def.h:249:3: note: in expansion of 
macro 'LANG_HOOKS_GETDECLS'
   LANG_HOOKS_GETDECLS, \
   ^~~~~~~~~~~~~~~~~~~
/vol/gcc/src/hg/trunk/local/gcc/langhooks-def.h:323:3: note: in expansion of 
macro 'LANG_HOOKS_DECLS'
   LANG_HOOKS_DECLS, \
   ^~~~~~~~~~~~~~~~
/vol/gcc/src/hg/trunk/local/gcc/objcp/objcp-lang.c:47:32: note: in expansion of 
macro 'LANG_HOOKS_INITIALIZER'
 struct lang_hooks lang_hooks = LANG_HOOKS_INITIALIZER;
                                ^~~~~~~~~~~~~~~~~~~~~~
make: *** [Makefile:1102: objcp/objcp-lang.o] Error 1

        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Reply via email to