On Tue, May 16, 2017 at 9:50 AM, REIX, Tony <tony.r...@atos.net> wrote:
> Tests:
>
> The change has been tested in 32bit and 64bit on AIX 6.1, 7.1 & 7.2 by using 
> the libbacktrace (with XCOFF support) within a signal handler context (we 
> used a specific back.c program).
> And it has been tested with Go tests on AIX for sure (recover tests on 
> SIGSEGV do not work without this change).
>
> ChangeLog:
>
> * config/rs6000/aix-unwind.h (ppc_aix_fallback_frame_state): Add 64 bit 
> support for AIX 6.1 and 7.X and 32 bit support for AIX 7.2.

If ppc_aix_fallback_frame_state is used for both 32 bit and 64 bit,
there is no need to define it twice.  Just move the
MD_FALLBACK_FRAME_STATE_FOR macro definition outside the #ifdef.  This
also needs a separate ChangeLog comment.

The function that you modified is "ucontext_for".  Please use that
name in the ChangeLog entry.

Will you need someone to apply the patch for you?

Thanks, David

Reply via email to