Hi Will,
On Wed, May 17, 2017 at 01:44:45PM -0500, Will Schmidt wrote:
> --- a/gcc/testsuite/gcc.target/powerpc/fold-vec-div-floatdouble.c
> +++ b/gcc/testsuite/gcc.target/powerpc/fold-vec-div-floatdouble.c
> @@ -1,9 +1,9 @@
> /* Verify that overloaded built-ins for vec_div with float and
> - double inputs for VSX produce the right results with -mvsx. */
> + double inputs for VSX produce the right results. */
>
> /* { dg-do compile } */
> /* { dg-require-effective-target powerpc_vsx_ok } */
> -/* { dg-options "-maltivec" } */
> +/* { dg-options "-mvsx" } */
It is more future-proof if you use -O2 (or -O1) here, if you do not
actually need -O0.
> --- a/gcc/testsuite/gcc.target/powerpc/fold-vec-div-longlong.c
> +++ b/gcc/testsuite/gcc.target/powerpc/fold-vec-div-longlong.c
> @@ -2,8 +2,8 @@
> inputs produce the right results. */
>
> /* { dg-do compile } */
> -/* { dg-require-effective-target powerpc_p8vector_ok } */
> -/* { dg-options "-maltivec -mpower8-vector -O3" } */
> +/* { dg-require-effective-target powerpc_vsx_ok } */
> +/* { dg-options "-mvsx -O2" } */
Does this one need p8 and VSX? The only insns you test for are plain
GPR insns (divd and divdu) (but perhaps some other are generated as well?).
You do need 64-bit though, for those divd instructions:
/* { dg-require-effective-target lp64 } */
is easiest (unless you really really care for -m32 -mpowerpc64).
> --- a/gcc/testsuite/gcc.target/powerpc/fold-vec-mult-int128-p8.c
> +++ b/gcc/testsuite/gcc.target/powerpc/fold-vec-mult-int128-p8.c
> @@ -4,7 +4,7 @@
> /* { dg-do compile } */
> /* { dg-require-effective-target powerpc_p8vector_ok } */
> /* { dg-require-effective-target int128 } */
> -/* { dg-options "-maltivec -mvsx -mpower8-vector" } */
> +/* { dg-options "-mpower8-vector" } */
> /* { dg-additional-options "-maix64" { target powerpc-ibm-aix* } } */
This also needs to test for 64-bit (since you want mulld etc. generated).
That -maix64 option then isn't needed I think (won't hurt though).
The rest looks good I think. Please do one last (hopefully!) pass over
this, and commit. Thanks,
Segher
