Hi Daniel, > There are a few issues with my ms-sysv.exp tests: > > 1. Use of gas extensions in do_test.S cause breakages on Solaris, > 2. Parallelization breaks when no make -j<jobs> flag is passed, > 3. Builds aren't adding TEST_ALWAYS_FLAGS, so log files filled with > color escape codes, and > 4. The "test unsupported" message is being spammed once for each -j<job> > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80759 > > I've broken this apart into two patches because I don't know if you'll > agree with the first one. I fixed the make -j<n> issue and moved the > parallelization code into a new gcc/target/lib/parallelize.exp in the first > patch and fixed all of the other issues in the second. I've removed all > usage of gas .struct in my assembly file, used hard-coded the offsets into > the code and added asserts to main.c to make sure they don't change. > > I've bootstrapped and retested on x86_64 Linux and have asked Rainer to > retest on Solaris. Presuming that succeeds, are you OK with this change?
unfortunately, it still doesn't, as explained in the PR. The multilib support is still wrong/non-existant. > (I have SVN write privs now, so I can even commit it myself). Please always include ChangeLog entries with your patch submissions so one can easily see what you've change (cf. https://gcc.gnu.org/contribute.html). Thanks. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University
