On Fri, May 26, 2017 at 12:14 PM, Richard Biener <richard.guent...@gmail.com> wrote: > On Tue, May 23, 2017 at 6:22 PM, Bin Cheng <bin.ch...@arm.com> wrote: >> Hi, >> This patch set factors out runtime alias check code from >> tree-vect-data-refs.c >> and tree-vect-loop-manip.c as general interfaces in tree-data-ref.c. With >> this >> change other optimizers like tree loop distribution could version loop wrto >> the >> runtime alias checks. During this work, I also found current code has issues >> with negative DR_STEP. This patch set fixes the issue as tracked in PR80815. >> >> This is the first patch simply moves compare_tree to tree.c and exposes it. >> Bootstrap and test on x86_64 and AArch64, is it OK? > > I think the name is quite bad for an exported function given for INTEGER_CSTs > it doesn't return anything resembling a comparison result. Also (not > your fault) > it doesn't seem to handle hash collisions nor have a suitable fallback for > trees it doesn't handle. > > I don't have a good suggestion for the name but tree.c exported fns should > have higher standards regarding their implementation... Hmm, I don't have idea to generalize it for the moment, so OK to rename it to data_ref_compare_tree and move it to tree-data-ref.c? It needs to be external symbol though.
Thanks, bin > > Richard. > > > >> Thanks, >> bin >> >> 2017-05-22 Bin Cheng <bin.ch...@arm.com> >> >> * tree-vect-data-refs.c (compare_tree): Move ... >> * tree.c (compare_tree): ... to here. >> * tree.h (compare_tree): New decalaration.
