Commited as r248868. Thanks. Paul.
On Mon, Jun 5, 2017 at 4:41 AM, Matthew Fortune <matthew.fort...@imgtec.com> wrote: > Hi Paul, > > Paul Hua <paul.hua...@gmail.com> writes: >> cc: Matthew. >> >> ping. > > Sorry a little slow on the reply. > >> On Thu, Jun 1, 2017 at 3:35 PM, Paul Hua <paul.hua...@gmail.com> wrote: >> > Hi, >> > >> > There are duplicate testcase in gcc.target/mips dir. >> > >> > div-5.c same as div-9.c. >> > div-6.c same as div-10.c. >> > div-7.c same as div-11.c. >> > div-8.c same as div-12.c. >> > >> > Is this deliberate? > > I see no evidence of this being deliberate and has been like this since > the original commit. > >> > Otherwise, the attached patch fixing this. >> > >> > >> > Paul. >> > >> > ***ChangeLog*** >> > >> > 2017-06-01 Chenghua Xu <paul.hua...@gmail.com> >> > >> > Remove duplicate div-x testcase. > > These kind of comments don't tend to go in a changelog. > >> > * gcc.target/mips/div-9.c: Delete. > > You could say "Delete duplicate test" here if you want though. > >> > * gcc.target/mips/div-10.c: Ditto. >> > * gcc.target/mips/div-11.c: Ditto. >> > * gcc.target/mips/div-12.c: Ditto. > > Otherwise OK. I can't remember if you have write access let me know > if you need it committing. Thanks for finding this. > > Matthew