PING 4: For review
Hi,
Can someone please review the patch:
http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01441.html
The previous discussion about the patch can be referred in the earlier
communication below.
Thanks,
Jayant Sonar
===== Begin Message ======
-----Original Message-----
From: Sumanth Gundapaneni
Sent: Monday, May 30, 2011 6:57 PM
To: 'Joseph Myers'
Cc: gcc-patches@gcc.gnu.org; r...@redhat.com; Jayant R. Sonar
Subject: RE: CR16 Port addition
Hi Joseph and Richard,
Thanks for your time in reviewing the CR16 port and once again I am grateful
for your valuable suggestions.
Please find attached the patch "cr16-gcc.patch" which contains modifications
as suggested by Joseph in his previous mail.
For your kind information, I am providing the recent posts regarding
CR16 patches.
Initial post : http://gcc.gnu.org/ml/gcc-patches/2010-12/msg01676.html
Second post : http://gcc.gnu.org/ml/gcc-patches/2011-01/msg00803.html
Third post : http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00624.html
Fourth post : http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01441.html
Please review the patch and let me know if there should be any modifications in
it.
Joseph, please go through my explanation for your comments.
>Please remove the remaining top level configure changes from the patch.
The top level configure changes have been removed as advised.
>Now you seem to have a stray change to the generated file
>libstdc++-v3/configure. Again, you can probably just eliminate this
The configure changes in libtsdc++-v3 are removed too and you can find
the same in the updated patch.
>and make the code in unwind-dw2-* use those macros,
>instead of having separate copies of the files.
A new file unwind-helper.h file is created in libgcc/config/cr16 directory
as per your suggestion and defined a few macros in this newly defined file
which are getting called from gcc/unwind-dw2.c. Please review the same
and do let me know for further modifications, if any. We have identified
issues related to exception handling using prints in unwind code and
will debug the same to a greater extent in near future with further
development of GNU based tools.
>Since you first submitted the port, a file contrib/config-list.mk
"cr16-elf" is added to config-list.mk file.
gcc/ChangeLog:
--------------
2011-05-28 Sumanth G <sumanth.gundapan...@kpitcummins.com>
Jayant R Sonar <jayant.so...@kpitcummins.com>
* config.gcc: Add cr16-* support.
* doc/extend.texi: Document cr16 extensions.
* doc/install.texi: Document cr16 install.
* doc/invoke.texi: Document cr16 options.
* doc/md.texi: Document cr16 constraints.
* config/cr16/cr16.c: New file.
* config/cr16/cr16.h: New file.
* config/cr16/cr16.md: New file.
* config/cr16/cr16.opt: New file.
* config/cr16/cr16-libgcc.s: New file.
* config/cr16/cr16-protos.h: New file.
* config/cr16/divmodhi3.c: New file.
* config/cr16/predicates.md: New file.
* config/cr16/constraints.md: New file.
* config/cr16/t-cr16: New file.
libgcc/ChangeLog:
-----------------
2011-05-28 Sumanth G <sumanth.gundapan...@kpitcummins.com>
Jayant R Sonar <jayant.so...@kpitcummins.com>
* config.host: Add National Semiconductor CR16 target (cr16-*-*).
* config/cr16/crti.S: New file.
* config/cr16/crtlibid.S: New file.
* config/cr16/crtn.S: New file.
* config/cr16/t-cr16: New file.
* config/cr16/unwind-helper.h: New file.
contrib/ChangeLog:
----------
2011-05-28 Sumanth G <sumanth.gundapan...@kpitcummins.com>
Jayant R Sonar <jayant.so...@kpitcummins.com>
* config-list.mk: Add National Semiconductor CR16 target.
Thanks in advance,
Sumanth G,
PUNE (India).
===== End Message ======
