On 07/03/2017 04:08 PM, Thomas Schwinge wrote:
Hi!

On Mon, 26 Jun 2017 17:29:11 +0200, Jakub Jelinek <ja...@redhat.com> wrote:
On Mon, Jun 26, 2017 at 03:26:57PM +0000, Joseph Myers wrote:
On Mon, 26 Jun 2017, Tom de Vries wrote:

2. Handle GOMP_OPENACC_NVPTX_{DISASM,SAVE_TEMPS} in libgomp nvptx plugin

This patch adds handling of:
- GOMP_OPENACC_NVPTX_SAVE_TEMPS=[01], and
- GOMP_OPENACC_NVPTX_DISASM=[01]

Why the "OPENACC" in these names?

I took the format from 'GOMP_OPENACC_DIM'.

Doesn't this debugging aid apply to
any variant of offloading?

I guess you're right. These environment variables would also be applicable for f.i. offloading via openmp on nvptx. I'll strip the 'OPENACC_' bit from the variables.

The filename used for dumping the module is plugin-nvptx.<pid>.cubin.

Also, I suggest to make these names similar to their controlling options,
that is: "gomp-nvptx*", for example.


Makes sense, will do.

Thanks,
- Tom

Reply via email to