On Tue, Jul 4, 2017 at 10:51 PM, Jakub Jelinek <ja...@redhat.com> wrote:
> On Tue, Jul 04, 2017 at 10:41:26PM +0200, Uros Bizjak wrote:
>> Hello!
>>
>> Apparently, Intel changed operand order with the new intrinsic
>> reference release version. Attached patch updates gcc intrinsic
>> headers accordingly.
>>
>> 2017-07-04 Uros Bizjak <ubiz...@gmail.com>
>>
>> PR target/81294
>> * config/i386/adxintrin.h (_subborrow_u32): Swap _X and _Y
>> arguments in the call to __builtin_ia32_sbb_u32.
>> (_subborrow_u64): Swap _X and _Y arguments in the call to
>> __builtin_ia32_sbb_u64.
>>
>> testsuite/ChangeLog:
>>
>> 2017-07-04 Uros Bizjak <ubiz...@gmail.com>
>>
>> PR target/81249
>> * gcc.target/i386/adx_addcarryx32-2.c (adx_test): Swap
>> x and y arguments in the call to _subborrow_u32.
>> * gcc.target/i386/adx_addcarryx64-2.c (adx_test): Swap
>> x and y arguments in the call to _subborrow_u64.
>> * gcc.target/i386/pr81294-1.c: New test.
>> * gcc.target/i386/pr81294-2.c: Ditto.
>>
>> Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}.
>>
>> Committed to mainline SVN, willbe backported to release branches.
>
> When it goes into release branches, it needs changes.html changes
> for each of those to make users aware of that.
> 7.2 will have rc after mid July, so if you want it in 7.2, it should be
> committed before that. 5.5 + 5.x branch closing will be around that time
> too.
IMO, we should change only gcc-7 release branch, so developers can
test for gcc-7.2+ to determine which release swapped arguments of
mentioned intrinsics.
The attached doc patch adds commented-out generic gcc-7.2 entry plus
the above target-specific change.
OK for branch?
Uros.
Index: htdocs/gcc-7/changes.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-7/changes.html,v
retrieving revision 1.85
diff -u -r1.85 changes.html
--- htdocs/gcc-7/changes.html 10 May 2017 11:39:41 -0000 1.85
+++ htdocs/gcc-7/changes.html 13 Jul 2017 19:19:02 -0000
@@ -1230,5 +1230,25 @@
complete (that is, it is possible that some PRs that have been fixed
are not listed here).</p>
+<!-- .................................................................. -->
+<!--
+<h2><a name="7.2">GCC 7.2</a></h2>
+
+<p>This is the <a
href="https://gcc.gnu.org/bugzilla/buglist.cgi?bug_status=RESOLVED&resolution=FIXED&target_milestone=7.2";>list
+of problem reports (PRs)</a> from GCC's bug tracking system that are
+known to be fixed in the 7.2 release. This list might not be
+complete (that is, it is possible that some PRs that have been fixed
+are not listed here).</p>
+
+<h3>Target Specific Changes</h3>
+
+<h4>IA-32/x86-64</h4>
+ <ul>
+ <li>The argument order of _subborrow_u32 and _subborow_u64
+ intrinsics has been changed to follow the latest update
+ to the reference documentation.</li>
+ </ul>
+-->
+
</body>
</html>
