On 07/26/2017 06:25 PM, David Malcolm wrote:
str.format was introduced in Python 2.6, so presumably the minimum
python 2 version here is at least 2.6+; for Python 3 I believe it was
present in Python 3.0 onwards.
Hm… Python 2.6 is fairly old: last binary release was ages ago, last
source release was in 2013. Do you think it’s worth supporting it?
+def check(predicate, message):
+ """
+ If `predicate` is True, emit a PASS message, otherwise emit a
FAIL one.
A very nitpicky nitpick: this comment should be spelled as "is true"
(lowercase), rather than "is True" since the requirement is that
predicate's "truth value" is true, rather than predicate *is* the
boolean "True" singleton; e.g. if someone passes in an int as
predicate, its nonzero-ness would be used, rather than always being
false (since no int *is* the boolean singleton "True").
I agree with you: I updated the patch on my machine. Thank you!
--
Pierre-Marie de Rodat
