On Thu, 6 Oct 2011, Artem Shinkarov wrote: > On Thu, Oct 6, 2011 at 3:27 AM, Hans-Peter Nilsson <h...@bitrange.com> wrote: > > Write that changelog entry as: > > > > PR middle-end/50607 > > * c-tree.h (c_expr_t): New typedef for struct c_expr. > > (C_EXPR_APPEND): New macro. > > * c-parser.c (c_parser_get_builtin_args): Preserve > > original_tree_code of c_expr structure. > > (c_parser_postfix_expression): Adjust to the new function. > > > > (note top marker and without the "Fixes...") > > and there'll be an automatic entry in bugzilla, like for example > > PR50609. You still have to close the bugzilla entry manually > > (not all noteworthy fixes are reason to close a bug report). > Thanks for the advice, I didn't know about the automatic mail.
Correction: for the automatic-bugzilla-comment machinery to work, you have to mention it in the svn *checkin message* but it is advised anyway to have this equivalent to the body of the changelog entry. (In emacs, mark the ChangeLog text and do M-| "svn ci -F /dev/stdin ChangeLog files-that-were-modified".) > As for closing bugzilla entry, I would prefer to > make sure that the patch really fixes the problem. It would be very > helpful if you could confirm this. Sorry, I don't have an autotester result ready to confirm. (But thanks for asking, I had disabled my cris-elf autotester and forgot to re-enable it!) It is sufficient that you've done this yourself; you need to use your @gcc.gnu.org bugzilla account. Don't worry, you'll be reminded if the bug is closed prematurely. :) brgds, H-P
