Re: [PATCH, rs6000] Clean up capitalized diagnostic messages

[Martin Sebor]

On 08/02/2017 09:29 AM, Bill Schmidt wrote:
Hi,
Jakub pointed out that we've had several error messages slip into the POWER 
back end
that incorrectly start with a capital letter.  This patch hunts those down and 
cleans
them up.

Others have already commented on some aspects of the patch but
let me suggest that using the option that controls it instead
of changing the spelling of AltiVec would bypass the whole
capitalization issue and might also provide an additional detail
that may otherwise not be immediately obvious.

Also, while making changes to the diagnostics, it would be great
to also add quoting around the built-in names and option names as
in:

--- gcc/config/rs6000/rs6000-c.c        (revision 250791)
+++ gcc/config/rs6000/rs6000-c.c        (working copy)
@@ -6802,7 +6802,7 @@ altivec_resolve_overloaded_builtin (location_t loc
     if (unsupported_builtin)
       {
        const char *name = rs6000_overloaded_builtin_name (fcode);
-       error ("Builtin function %s not supported in this compiler 
configuration",
+       error ("builtin function %s not supported in this compiler 
configuration",

use %qs instead:

  error ("builtin function %qs not supported in this compiler 
configuration", ...);

and similarly here:

+           error ("power9 target option is incompatible with -mcpu=<xxx> for "
                   "<xxx> less than power9");

Here too, I suggest to consider using and quoting an option that
enables the to power9 target rather than using power9 as a plain
word.

Martin