On 07/13/2017 02:54 AM, Richard Sandiford wrote:
> The comment for widest_int_mode said that it returns "the widest integer
> mode no wider than SIZE", but it actually returns the widest integer
> mode that is narrower than SIZE.  In practice SIZE is always greater
> than 1, so it can always pick QImode in the worst case.  The VOIDmode
> paths seem to be dead.
> 
> gcc/
> 2017-07-13  Richard Sandiford  <richard.sandif...@linaro.org>
>           Alan Hayward  <alan.hayw...@arm.com>
>           David Sherwood  <david.sherw...@arm.com>
> 
>       * expr.c (widest_int_mode_for_size): Make the comment match the code.
>       Return a scalar_int_mode and assert that the size is greater than
>       one byte.
>       (by_pieces_ninsns): Update accordingly and remove VOIDmode handling.
>       (op_by_pieces_d::op_by_pieces_d): Likewise.
>       (op_by_pieces_d::run): Likewise.
>       (can_store_by_pieces): Likewise.
OK.
jeff

Reply via email to