On Wed, Aug 30, 2017 at 12:17 PM, Martin Liška <mli...@suse.cz> wrote:
> On 08/30/2017 11:18 AM, Richard Biener wrote:
>> On Wed, Aug 30, 2017 at 11:12 AM, Martin Liška <mli...@suse.cz> wrote:
>>> Hi.
>>>
>>> Following patch compares also constraints of input and output operands of 
>>> ASM statements.
>>> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
>>>
>>> Ready to be installed?
>>
>> It's now no longer "compare_tree_list_operand" but compare_asm_constraint
>> where there's no need to walk TREE_CHAIN either.
>
> Yep, it desires a refactoring.
>
> Is it fine for trunk?

Ok.

Richard.

> Martin
>
>>
>> So can you refactor this a bit?
>>
>>> Martin
>>>
>>> gcc/ChangeLog:
>>>
>>> 2017-08-28  Martin Liska  <mli...@suse.cz>
>>>
>>>         PR inline-asm/82001
>>>         * ipa-icf-gimple.c (func_checker::compare_tree_list_operand):
>>>         Compare TREE_PURPOSE of asm inputs and outputs.
>>>
>>> gcc/testsuite/ChangeLog:
>>>
>>> 2017-08-28  Martin Liska  <mli...@suse.cz>
>>>
>>>         PR inline-asm/82001
>>>         * gcc.dg/ipa/pr82001.c: New test.
>>> ---
>>>  gcc/ipa-icf-gimple.c               | 10 ++++++++++
>>>  gcc/testsuite/gcc.dg/ipa/pr82001.c | 21 +++++++++++++++++++++
>>>  2 files changed, 31 insertions(+)
>>>  create mode 100644 gcc/testsuite/gcc.dg/ipa/pr82001.c
>>>
>>>
>

Reply via email to