On 08/04/2017 04:04 PM, David Malcolm wrote: > This patch provides a way to "watermark" binaries with > metadata. It's used later in the patch kit to watermark > binaries with static analysis results and metadata. > > See: > https://fedoraproject.org/wiki/Toolchain/Watermark > > Note: this is a version of Nick Clifton's "annobin" gcc plugin: > https://nickc.fedorapeople.org/ > heavily hacked up by me: > * removed everything (including plugin support) not needed by > later patches in the kit > * rewritten as an API, rather than as a plugin > * removed annobin_inform (..., "ICE: ...") calls in favor of > gcc_assert. > * line-wrapped > * added a annobin_ensure_init to initialize annobin_is_64bit. > * added #ifndef guard to annobin.h > > It includes the commits: > * Remove size limit on string passed to annobin_output_string_note > * Version 2 of spec: Add a GA prefix to all names So we're really like to have just one annobin that handles Nick's needs as well as yours. Having two just seems silly.
The idea behind using a plugin was to allow annobin to continue development/releases independent of the trunk of GCC. Ideally we'd be able to re-use new versions of annobin in older versions of GCC that have a fairly long lifecycle. I think you and Nick need to coordinate in this space. jeff
