On 09/05/2017 09:05 PM, Jiong Wang wrote: > 2017-08-22 9:18 GMT+01:00 Jiong Wang <jiong.w...@foss.arm.com>: >> On 10/08/17 17:39, Jiong Wang wrote: >>> >>> Hi, >>> >>> A new vendor CFA DW_CFA_AARCH64_negate_ra_state was introduced for >>> ARMv8.3-A >>> return address signing, it is multiplexing DW_CFA_GNU_window_save in CFA >>> vendor >>> extension space. >>> >>> This patch adds necessary code to make it available to external, the GDB >>> patch (https://sourceware.org/ml/gdb-patches/2017-08/msg00215.html) is >>> intended >>> to use it. >>> >>> A new DW_CFA_DUP for it is added in dwarf2.def. The use of DW_CFA_DUP >>> is to >>> avoid duplicated case value issue when included in libiberty/dwarfnames. >>> >>> Native x86 builds OK to make sure no macro expanding errors. >>> >>> OK for trunk? >>> >>> 2017-08-10 Jiong Wang <jiong.w...@arm.com> >>> >>> include/ >>> * dwarf2.def (DW_CFA_AARCH64_negate_ra_state): New DW_CFA_DUP. >>> * dwarf2.h (DW_CFA_DUP): New define. >>> >>> libiberty/ >>> * dwarfnames.c (DW_CFA_DUP): New define. >>>
I'd like to add a +1 vote for this patch. I was confused more than once in the iterations of the pending gdb patch that were adding references to "DW_CFA_GNU_window_save" in Aarch64 code that has absolutely nothing to do with SPARC register windows, and asked Jiong whether we could add an Aarch64-specific name for the constant. Thanks, Pedro Alves
