Hi Andrew, Yes I noticed the changelog after I sent it.
But I have a new version of the patch on internal review Which is why I didn't ping this one. I'll send it out after the Cauldron. Thanks, Tamar ________________________________________ From: Andrew Pinski <pins...@gmail.com> Sent: Saturday, September 9, 2017 7:57:00 AM To: Tamar Christina Cc: GCC Patches; nd; James Greenhalgh; Richard Earnshaw; Marcus Shawcroft Subject: Re: [PATCH][GCC][AArch64] Restrict lrint inlining on ILP32. On Fri, Aug 11, 2017 at 2:58 AM, Tamar Christina <tamar.christ...@arm.com> wrote: > Hi All, > > The inlining of lrint isn't valid in all cases on ILP32 when > -fno-math-errno is used because an inexact exception is raised in > certain circumstances. > > For ILP32 I now restrict the inlining only when -fno-trapping-math > is also specified. > > This fixed PR/81800. > > Regtested on aarch64-none-linux-gnu and no regressions. > > Ok for trunk? I can't approve this patch but it looks good except for your changelog does not match what the code is doing. Maybe: Add check on !ilp32 or !flag_trapping_math. Thanks, Andrew > > Thanks, > Tamar > > gcc/ > 2017-08-11 Tamar Christina <tamar.christ...@arm.com> > > PR target/81800 > * config/aarch64/aarch64.md (lrint<GPF:mode><GPI:mode>2): Add > flag_trapping_math. > > gcc/testsuite/ > 2017-08-11 Tamar Christina <tamar.christ...@arm.com> > > * gcc.target/aarch64/inline-lrint_2.c (dg-options): Add > -fno-trapping-math. > > --
