On Sun, Sep 17, 2017 at 7:27 PM, Jakub Jelinek <ja...@redhat.com> wrote:
> On Sun, Sep 17, 2017 at 05:47:11PM +0200, Uros Bizjak wrote:
>> > The postreload change is ok.
>>
>> The revert is OK even without approval.

I see.

The patch is also OK.

Thanks,
Uros.

> Well, it isn't a pure reversion, it is reversion plus addition of
>   const char *name = LABEL_NAME (label);
>   PUT_CODE (label, NOTE);
>   NOTE_KIND (label) = NOTE_INSN_DELETED_LABEL;
>   NOTE_DELETED_LABEL_NAME (label) = name;
> to the end of ix86_init_large_pic_reg.
>
>> >> 2017-09-13  Jakub Jelinek  <ja...@redhat.com>
>> >>
>> >>       PR target/82145
>> >>       * postreload.c (reload_cse_simplify_operands): Skip
>> >>       NOTE_INSN_DELETED_LABEL similarly to skipping CODE_LABEL.
>> >>       * config/i386/i386.c (ix86_init_large_pic_reg): Revert 2017-09-01
>> >>       changes.  Turn CODE_LABEL into NOTE_INSN_DELETED_LABEL immediately.
>> >>       (ix86_init_pic_reg): Revert 2017-09-01 changes.
>> >>
>> >>       * gcc.target/i386/pr82145.c: New test.
>
>         Jakub

Reply via email to