Hi Daniel,
> On 09/22/2017 02:18 AM, Rainer Orth wrote:
>> Hi Daniel,
>>
>>> On 09/21/2017 05:18 PM, Daniel Santos wrote:
>>>> So libgcc doesn't use a config.in. :(
>>> Scratch that, I forgot that we're using gcc/config.in via auto-host.h.
>>> So I only have to add this to gcc/configure.ac and it will be available
>>> for my libgcc header -- this is what I used to sniff out support for the
>>> .hidden directive.
>> Please don't go that route: it's totally the wrong direction. There's
>> work going on to further decouple libgcc from gcc-private headers and
>> configure results. libgcc already has its own configure tests for
>> assembler features, and its own config.in. What's wrong with adapting
>> libitm's avx test in libitm/acinclude.m4 (LIBITM_CHECK_AS_AVX) for
>> libgcc? Should be trivial...
>>
>> Rainer
>>
>
> Oops, I just saw your email after submitting my other patch. Yes, I am
> mistaken about config.in, sorry about that. I didn't see a config.h
> file, but examining further it looks like it outputs to auto-target.h.
> Also, I was looking for some HAVE_AS* macros, but they are named
> differently.
Right: though some are for assembler features, the macros are named
differently.
> I had previously included gcc's auto-host.h since it was in the include
> path in order to use HAVE_AS_HIDDEN, so in order to decouple this I'll
HAVE_GAS_HIDDEN actually ;-)
> need to add that check into libgcc/configure.ac as well. Again,
> shouldn't be that much code. Sound sane to you?
You could do that, but it was already used before your patches, so
please separate it from the current issue if you go down that route.
libgcc is still full of cleanup possibilities :-)
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
