Hi Carl, On Mon, Sep 18, 2017 at 11:31:07AM -0700, Carl Love wrote: > * gcc.target/powerpc/builtins-5-p9-runnable.c: Add new runable test file > for the new built-ins and the existing built-ins.
Typo ("runable"). > (define_expand "altivec_lvsr" > - [(use (match_operand:V16QI 0 "register_operand" "")) > + [(use (match_operand:V16QI 0 "altivec_register_operand" "")) > (use (match_operand:V16QI 1 "memory_operand" ""))] Empty constraint strings in define_expand is the default, just leave them out. > +;; Expand for builtin xl_len_r > +(define_expand "xl_len_r" > + [(match_operand:V16QI 0 "vsx_register_operand" "=wa") > + (match_operand:DI 1 "register_operand" "b") > + (match_operand:DI 2 "register_operand" "r")] > + "" Non-empty constraints in an expander do not really make sense either :-) All the rest looks fine. Please fix up the expanders and commit. Thanks! Segher