On Fri, 13 Oct 2017, Nathan Sidwell wrote: > In figuring out a problem with CODE_CONTAINS_STRUCT I noticed that: > > 1) the tree_contains_struct array is unsigned char. bool seems a better > choice now we're in C++-land. > > 2) the MARK_TS_FOO macros used the 'do ... while (0)' idiom. But there's no > need for such verbosity. These are 'ary[index] = true' setters -- other > setters don't use do while: > #define SET_DECL_ASSEMBLER_NAME(NODE, NAME) \ > (DECL_ASSEMBLER_NAME_RAW (NODE) = (NAME)) > > We can combine them with the comma operator, not make separate statements. > > Fixed thusly, ok?
OK. Richard. > nathan > -- Richard Biener <rguent...@suse.de> SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg)