On 10/13/2017 06:35 AM, Jonathan Wakely wrote:
This adds an item to the list of options for the -fdump-tree option,
because we show an example using 'vect' but don't document it.
OK for trunk?
No, I think this patch is addressing an imaginary bug. I see no "vect"
option listed in the dump_options array in dumpfile.c.
I think this is the example in question:
@smallexample
gcc -O2 -ftree-vectorize -fdump-tree-vect-blocks=foo.dump
-fdump-tree-pre=/dev/stderr file.c
@end smallexample
outputs vectorizer dump into @file{foo.dump}, while the PRE dump is
output on to @file{stderr}. If two conflicting dump filenames are
given for the same pass, then the latter option overrides the earlier
one.
I think the "vect" in this example is part of the pass name to be
dumped, not an option modifying the dump output. E.g. this is explicit
in an older version of the GCC manual
https://gcc.gnu.org/onlinedocs/gcc-4.8.5/gcc/Debugging-Options.html#Debugging-Options
which includes the example AND documents "vect" as one of the tree dumps
you can ask for. The current version of this documentation doesn't
explicitly list all the tree dumps any more, but GCC does still accept
-fdump-tree-vect.
Is there any logic to the order of those options? Would it makes sense
to order them alphabetically?
My advice would be to move the =filename stuff out of the table (it's
not really an option like the others) and refactor it into a paragraph
before the option discussion, and in the table list "all" and "optall"
first and then alphabetize the remaining entries (and make sure
everything in the dump_options array is documented).
-Sandra