On Sat, Oct 14, 2017 at 12:16 PM, Andrew Pinski <pins...@gmail.com> wrote: > On Mon, Sep 18, 2017 at 2:06 PM, Uros Bizjak <ubiz...@gmail.com> wrote: >> On Tue, Sep 5, 2017 at 3:50 PM, Uros Bizjak <ubiz...@gmail.com> wrote: >>> Revised patch, incorporates fixes from Alexander's review comments. >>> >>> I removed some implementation details from Alexander's description of >>> memory_blockage named pattern. >>> >>> >>> 2017-09-05 Uros Bizjak <ubiz...@gmail.com> >>> >>> * target-insns.def: Add memory_blockage. >>> * optabs.c (expand_memory_blockage): New function. >>> (expand_asm_memory_barrier): Rename ... >>> (expand_asm_memory_blockage): ... to this. >>> (expand_mem_thread_fence): Call expand_memory_blockage >>> instead of expand_asm_memory_barrier. >>> (expand_mem_singnal_fence): Ditto. >>> (expand_atomic_load): Ditto. >>> (expand_atomic_store): Ditto. >>> * doc/md.texi (Standard Pattern Names For Generation): >>> Document memory_blockage instruction pattern. >>> >>> Bootstrapped and regression tested together with a followup x86 patch >>> on x86_64-linux-gnu {,-m32}. >>> >>> OK for mainline? >> >> PING, original patch at [1]. >> >> [1] https://gcc.gnu.org/ml/gcc-patches/2017-09/msg00270.html > > This patch broke aarch64-linux-gnu and aarch64-elf building: > > ./.deps/optabs-query.TPo > /home/jenkins/workspace/BuildToolchainAARCH64_thunder_elf_upstream/toolchain/scripts/../src/gcc/optabs-query.c > /home/jenkins/workspace/BuildToolchainAARCH64_thunder_elf_upstream/toolchain/scripts/../src/gcc/optabs.c: > In function ‘void expand_memory_blockage()’: > /home/jenkins/workspace/BuildToolchainAARCH64_thunder_elf_upstream/toolchain/scripts/../src/gcc/optabs.c:6301: > error: ‘gen_memory_blockage’ was not declared in this scope
Will fix ASAP: Index: optabs.c =================================================================== --- optabs.c (revision 253750) +++ optabs.c (working copy) @@ -6298,7 +6298,7 @@ static void expand_memory_blockage (void) { if (targetm.have_memory_blockage) - emit_insn (gen_memory_blockage ()); + emit_insn (targetm.gen_memory_blockage ()); else expand_asm_memory_blockage (); } Uros.