On Thu, Oct 19, 2017 at 10:15:44PM +0000, Joseph Myers wrote: > On Thu, 19 Oct 2017, Michael Meissner wrote: > > > 1) I switched to use DEF_EXT_LIB_BUILTIN to declare the _Float<N> > > and > > _Float<N>X functions. This allows treating __builtin_sqrtf128 the same > > as sqrtf128. > > It's not correct to do that unconditionally for all the existing > DEF_GCC_FLOATN_NX_BUILTINS functions. There should not be a public > huge_valf128 function any more than a public huge_val function, just > __builtin_huge_valf128. > > Rather, you should add a new DEF_EXT_LIB_FLOATN_NX_BUILTINS. It should be > used by the new functions, and by the existing copysign / fabs / nan > functions. It should not be used by the existing huge_val / inf / nans > functions.
Ok. Would an initial patch to go back to using DEF_GCC_BUILTIN (which means people would need to use __builtin_sqrtf128 and __builtin_fmaf128) be acceptable, while I delve into the appropriate incantations to get it to work as desired be ok? -- Michael Meissner, IBM IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA email: meiss...@linux.vnet.ibm.com, phone: +1 (978) 899-4797
