James,

The patch was test as required. However when I tested with the latest trunk 
there were two test failures that need to be updated because of my patch. 

The files gcc.target/aarch64/vect-vcvt.c was failing because the scan-assembler 
directives assumed the destination register was assumed to be an integer 
register. With my patch the destination can be an integer or fp register.

I fixed the failures and bootstrapped and tested on aarch64-linux-gnu. Okay for 
trunk?

2017-09-02  Michael Collison  <michael.colli...@arm.com>

        * config/aarch64/aarch64.md(<optab>_trunc><vf><GPI:mode>2):
        New pattern.
        (<optab>_trunchf<GPI:mode>2: New pattern.
        (<optab>_trunc<vgp><GPI:mode>2: New pattern.
        * config/aarch64/iterators.md (wv): New mode attribute.
        (vf, VF): New mode attributes.
        (vgp, VGP): New mode attributes.
        (s): Update attribute with SImode and DImode prefixes.
        * testsuite/gcc.target/aarch64/fix_trunc1.c: New testcase.
        * testsuite/gcc.target/aarch64/vect-vcvt.c: Fix scan-assembler
        directives to allow float or integer destination registers for
        fcvtz[su].

-----Original Message-----
From: James Greenhalgh [mailto:james.greenha...@arm.com] 
Sent: Monday, October 23, 2017 9:43 AM
To: Michael Collison <michael.colli...@arm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>; nd <n...@arm.com>
Subject: Re: [PING][PATCH][Aarch64] Improve int<->FP conversions

On Tue, Oct 17, 2017 at 01:17:04AM +0100, Michael Collison wrote:
> Patch updated with all comments from James.

OK with an appropriate ChangeLog and assuming it has been tested as required.

Thanks,
James

Reviewed-by: <james.greenha...@arm.com>


Attachment: gnutools-6527-v6.patch
Description: gnutools-6527-v6.patch

Reply via email to