On Thu, Oct 26, 2017 at 09:24:58PM +0200, Kamil Rytarowski wrote: > On 26.10.2017 21:19, Jakub Jelinek wrote: > > On Thu, Oct 26, 2017 at 09:02:25PM +0200, Kamil Rytarowski wrote: > >> 2017-10-26 Kamil Rytarowski <n...@gmx.com> > >> > >> * sanitizer_common/Makefile.am (sanitizer_common_files): Add > >> sanitizer_platform_limits_netbsd.cc. > >> * sanitizer_common/Makefile.in: Regenerated. > > > > Why is this needed? > > libsanitizer/configure.tgt will set UNSUPPORTED=1 for NetBSD. > > So, the rest of the libsanitizer port to NetBSD in GCC is missing too > > and should be submitted together with this change. > > > > There are missing symbols without sanitizer_platform_limits_netbsd.cc. > > I've planned to submit configure.tgt change separately. Should I squash > both changes into one commit?
Yes. The above change makes no sense without the configure.tgt one. Also, the gcc-patches submission should say where and how it has been tested. Jakub