On 10/31/2017 05:54 AM, Tsimbalist, Igor V wrote:
> The revised patch is attached. The differences are in what options are 
> defined and propagated to Makefile for CET enabling.
> 
> Ok for trunk?
> 
> Igor
> 
> 
>> -----Original Message-----
>> From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-
>> ow...@gcc.gnu.org] On Behalf Of Jeff Law
>> Sent: Wednesday, October 18, 2017 1:34 AM
>> To: Tsimbalist, Igor V <igor.v.tsimbal...@intel.com>; gcc-
>> patc...@gcc.gnu.org
>> Subject: Re: [PATCH 10/22] Enable building libcilkrts with Intel CET
>>
>> On 10/12/2017 02:13 PM, Tsimbalist, Igor V wrote:
>>> Enable building libcilkrts with CET options.
>>>
>>> libcilkrts/
>>>     * Makefile.am: Add AM_CXXFLAGS and XCXXFLAGS.
>>>     * configure.ac: Set CET_FLAGS, update XCFLAGS, XCXXFLAGS.
>>>     * Makefile.in: Regenerate.
>>>     * aclocal.m4: Likewise.
>>>     * configure: Likewise.
>>>
>> So like the other patches in this space, the inclusion of cet.h seems
>> wrong.  I don't see why this should be needed here.
>>
>> It's OK with that bit removed and once any prereqs are OK'd.
>>
>> jeff
> 
> 0010-Enable-building-libcilkrts-with-Intel-CET.PATCH
> 
> 
> From db5978749148cd35c97145ea52e7a5e07121b27e Mon Sep 17 00:00:00 2001
> From: Igor Tsimbalist <igor.v.tsimbal...@intel.com>
> Date: Thu, 10 Aug 2017 14:20:31 +0300
> Subject: [PATCH 10/21] Enable building libcilkrts with Intel CET
> 
> libcilkrts/
>       * Makefile.am: Add AM_CXXFLAGS.
>       * configure.ac: Set CET_FLAGS, update XCFLAGS, XCXXFLAGS.
>       * Makefile.in: Regenerate.
>       * aclocal.m4: Likewise.
>       * configure: Likewise.
OK.  Please wait to commit until entire set is ACK'd.

jeff

Reply via email to