On Nov 14, 2017, at 3:33 AM, Dominique d'Humières <domi...@lps.ens.fr> wrote:
>
>> Le 13 nov. 2017 à 18:40, Mike Stump <mikest...@comcast.net> a écrit :
>> On Nov 12, 2017, at 6:58 AM, H.J. Lu <hjl.to...@gmail.com> wrote:
>>>
>>> On Sun, Nov 12, 2017 at 6:22 AM, Dominique d'Humières
>>> <domi...@lps.ens.fr> wrote:
>>>> The following patch fixes PR68356, PR81210, and PR81693 on darwin.
>>>> ...
>>>
>>> I wrote these tests. These tests don't align stack to 16 bytes and
>>> should be skipped on Darwin.
>>
>> So, sounds like something based on:
>>
>> /* { dg-skip-if "sp not aligned to 16 bytes" { *-*-darwin } } */
>>
>> then. Ok with that change.
>
> Thanks for the review.
>
> Am I correct to understand that this apply to pr25967-*.c only?
>
> I’ld like to keep the PR numbers. Is it OK?
Feel free to keep the PR, but, I'd close the other two as dups of the first,
and then just list the first. The issue is that all of these test cases are 1
problem, so there should only be 1 PR. HJ's comment applies to all test cases
in your patch, and the problem appears to be the single non-16 byte stack on
all of them. Because of that alone, the test cases should be skipped for that
one reason, no matter the existence of other reasons why that test case should
be skipped.
