Hi, On Mon, Nov 27, 2017 at 06:40:09PM -0500, Michael Meissner wrote: > @@ -33,3 +35,13 @@ $(fp128_hw_obj) : $(srcdir)/config/rs6 > > $(fp128_ifunc_obj) : INTERNAL_CFLAGS += $(FP128_CFLAGS_SW) > $(fp128_ifunc_obj) : $(srcdir)/config/rs6000/t-float128-hw > + > +_mulkc3-hw.c: $(srcdir)/config/rs6000/_mulkc3.c > + rm -rf _mulkc3.c > + (echo "#define __mulkc3 __mulkc3_hw"; \ > + cat $(srcdir)/config/rs6000/_mulkc3.c) > _mulkc3-hw.c
Please don't -rf. -rf is a dangerous habit. This also won't work if anything tries to build _mulkc3-hw.c a second time; you have deleted its prerequisite. Maybe some other scheme is better? > --- libgcc/config/rs6000/t-float128 (revision 255177) > +++ libgcc/config/rs6000/t-float128 (working copy) > @@ -86,7 +86,7 @@ test: > for x in $(fp128_obj); do echo " $$x"; done; > > clean-float128: > - rm -rf $(fp128_softfp_src) > + rm -rf $(fp128_softfp_src) $(fp128_hardfp_src) > @$(MULTICLEAN) multi-clean DO=clean-float128 -rm to avoid warnings from rm if you clean without the files being there. Otherwise looks good. Thanks! Segher
