On Mon, Jan 15, 2018 at 10:00 AM, Jan Hubicka <hubi...@ucw.cz> wrote: >> Hi Jan, >> >> Can you review this patch? This blocks the GCC 7 backport. >> >> Thanks. >> >> H.J. >> >> >> ---------- Forwarded message ---------- >> From: H.J. Lu <hjl.to...@gmail.com> >> Date: Mon, Jan 15, 2018 at 8:45 AM >> Subject: [PATCH] i386: Don't use ASM_OUTPUT_DEF for TARGET_MACHO >> To: gcc-patches@gcc.gnu.org >> Cc: Uros Bizjak <ubiz...@gmail.com> >> >> >> ASM_OUTPUT_DEF isn't defined for TARGET_MACHO. Use ASM_OUTPUT_LABEL to >> generate the __x86_return_thunk label, instead of the set directive. >> Update testcase to remove the __x86_return_thunk label check. Since >> -fno-pic is ignored on Darwin, update testcases to sscan or "push" >> only on Linux. >> >> Tested with a cross compiler to x86_64-apple-darwin10.4.0. OK for >> trunk? >> >> H.J. >> --- >> gcc/ >> >> PR target/83839 >> * config/i386/i386.c (output_indirect_thunk_function): Use >> ASM_OUTPUT_LABEL, instead of ASM_OUTPUT_DEF, for TARGET_MACHO >> for __x86.return_thunk. > > Hmm, we really ought to merge it with the way normal thunks are output from > middle-end next stage1. > > OK > Honza
I checked it in and opened: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83868 Thanks. -- H.J.
