On Fri, Jan 19, 2018 at 8:36 AM, David Edelsohn <dje....@gmail.com> wrote:
> On Thu, Jan 18, 2018 at 9:56 AM, REIX, Tony <tony.r...@atos.net> wrote:
>>
>> Description:
>>  * This patch optimizes the time required for parsing the include files.
>>
>> Tests:
>>  * AIX: Build: SUCCESS
>>    - build made by means of gmake on AIX.
>>
>> ChangeLog:
>>   * xcoff.c: Optimize parsing of include files.
>
> Hi, Tony
>
> The ChangeLog should be more detailed.
>
> * xcoff.c (xcoff_incl_compare): New function.
> (xcoff_incl_search): New function.
> (xcoff_process_linenos): Use bsearch to find include file.
> (xcoff_initialize_fileline): Sort include file information.
>
>
> The rest is okay, although the calls to bsearch and backtrace_qsort
> don't follow the style of other files.
>
> This is okay.

I committed the patch with that ChangeLog entry.

Ian

Reply via email to