On Tue, Jan 23, 2018 at 07:30:49PM +0000, Paul Richard Thomas wrote:
> Janne, Thanks.
>
> Jakub, is this OK with you?
It is indeed quite late for such large ABI changes, some distributions are
about to start using the compiler by now. How much was it tested (on which
targets)? Has the debug info side of things been adjusted too (the
get_array_descr_info langhook)?
> >> I took the design choice choice to replace the dtype with a structure:
> >> typedef struct dtype_type
> >> {
> >> size_t elem_len;
> >> int version;
> >> int rank;
> >> int type;
> >> int attribute;
> >> }
> >> dtype_type;
Isn't this too wasteful? rank will be just 0-15, right?
What values can version have? What type? Do you need negative values for
any of those?
I think using unsigned char or unsigned short for some of those fields
should be sufficient, yeah, they don't necessarily need to be bitfields.
Jakub
