Hi All, Given the delay relative to the start of stage 3, I thought that I had better deal with this asap:
+ /* TODO: this works on any derived type when + it should only work with team_type. */ + if (team->ts.type != BT_DERIVED) Why don't you give the team_type derived type an attribute 'team_type' and test that? - code node is passed. The result type and library subroutine name + code ndoe is passed. The result type and library subroutine name typo +! Tests if team_number intrinsic fucntion works It's just as well that there is an 'n' in there, although it gives me an idea for a new type of fortran procedure that does what it says :-) Together with the change that Steve identified, this seems to me to be ready to go. (Jakub, This is all hidden behind the -fcoarray option. To my mind this is safe for release.) OK for trunk. Many thanks for this patch. Paul On 23 January 2018 at 05:45, Steve Kargl <s...@troutmask.apl.washington.edu> wrote: > I'm heading out of town for a meeting at the end of > week, so gfortran patches/reviews are on hold at the > moment. If someone else wants to step up to review > the patch, I won't object. > > -- > steve > > On Mon, Jan 22, 2018 at 08:29:41PM -0800, Damian Rouson wrote: >> Is Fortran 2018 teams patch ok for trunk? >> >> Damian >> >> On January 19, 2018 at 2:47:39 PM, Alessandro Fanfarillo (elfa...@ucar.edu) >> wrote: >> >> I can confirm that the little change suggested by Steve passes the >> regtests (on x86_64-pc-linux-gnu) and the regular tests using >> OpenCoarrays. >> >> On Fri, Jan 19, 2018 at 10:33 AM, Steve Kargl >> <s...@troutmask.apl.washington.edu> wrote: >> > On Fri, Jan 19, 2018 at 09:18:14AM -0800, Damian Rouson wrote: >> >> Thanks for catching that, Steve, and for responding, Alessandro. >> >> >> >> Anything else? >> >> >> > >> > I've only just started to look at the patch. Unfortunately, >> > I know zero about teams, so need to read the patch and F2018 >> > standard simultaneously. >> > >> > -- >> > Steve >> >> >> >> -- >> >> Alessandro Fanfarillo, Ph.D. >> Postdoctoral Researcher >> National Center for Atmospheric Research >> Mesa Lab, Boulder, CO, USA >> 303-497-1229 > > -- > Steve > 20170425 https://www.youtube.com/watch?v=VWUpyCsUKR4 > 20161221 https://www.youtube.com/watch?v=IbCHE-hONow -- "If you can't explain it simply, you don't understand it well enough" - Albert Einstein