Hi!

> This is the second patch that removes the non-ABI vec_insert4b and
> vec_extract4b builtin support.  It also removes the two existing test
> files for the non-ABI builtin instances.  A runnable test file for the
> ABI specified builtins was added by the first patch.

Looks good too; okay for trunk.  See changelog comments though.

> The patch should also be ported to GCC 7 so we are in compliance with
> the ABI.

Also okay for 7 (just like the previous patch) after simmering on trunk
for a bit.

Thanks,


Segher


>     2018-02-13  Carl Love  <c...@us.ibm.com>
> 
>         * config/rs6000/altivec.h: Remove vec_vextract4b and vec_vinsert4b.

        * config/rs6000/altvec.h (vec_vextract4b, vec_vinsert): Delete.

>         * config/rs6000/rs6000-builtin.def: Remove macro expansion for
>       VEXTRACT4B, VINSERT4B, VINSERT4B_DI and VEXTRACT4B.
>         * config/rs6000/rs6000.c: Remove case statements for
>       P9V_BUILTIN_VEXTRACT4B, P9V_BUILTIN_VEC_VEXTRACT4B,
>       P9V_BUILTIN_VINSERT4B, P9V_BUILTIN_VINSERT4B_DI,
>       and P9V_BUILTIN_VEC_VINSERT4B.
>         * config/rs6000/rs6000-c.c (altivec_expand_builtin): Remove entries 
> for
>       P9V_BUILTIN_VEC_VEXTRACT4B and P9V_BUILTIN_VEC_VINSERT4B.
>         * config/rs6000/vsx.md:
>         * doc/extend.texi: Remove vec_vextract4b, non ABI definitions for
>       vec_insert4b.
> 
>     gcc/testsuite/ChangeLog:
> 
>     2018-02-13  Carl Love  <c...@us.ibm.com>
>         * gcc.target/powerpc/p9-vinsert4b-1.c: Remove test file for non-ABI
>       tests.
>       * gcc.target/powerpc/p9-vinsert4b-2.c: Remove test file for non-ABI
>       tests.

[ Whitespace is totally jumbled in the changelog, I guess that is your
mail program. ]


Segher

Reply via email to