On 02/16/2018 05:48 PM, Jason Merrill wrote:
We hit the bug in this testcase because build_over_call replaces the
constructor with a dispatcher function, and then build_aggr_init_expr
doesn't recognize it as a constructor.
Messing with the DECL_NAME of the dispatcher seems messy, but copying
the DECL_CXX_CONSTRUCTOR_P flag is easy. So we can change the test in
build_aggr_init_expr, or change the definition of DECL_CONSTRUCTOR_P.
I lean toward the latter as more uniform, but not strongly. Do you
have an opinion?
Using the ctor name for the dispatcher doesn't seem wonky to me -- it is after
all a constructor. But then I've not looked at the code. Might be bored in
airports tomorrow ... If I fail to respond, go with your approach.
nathan
--
Nathan Sidwell
