Hi Carl,

On Fri, Feb 16, 2018 at 11:53:53AM -0800, Carl Love wrote:
> The following patch fixes a GCC internal compiler error on the test
> files:
> 
>   gcc/testsuite/gcc.target/powerpc/fold-vec-neg-longlong.p8.c
>   gcc/testsuite/gcc.target/powerpc/fold-vec-neg-longlong.p9.c
> 
> when compiled with -mcpu=power7.
> 
> See bugzilla https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84422.
> 
> The issue is the macro expansions enable the builtin support on pre
> Power 8 hardware.  The vec_neg() builtin is not supported for Power 7.

> 2018-02-16  Carl Love  <c...@us.ibm.com>
>       * gcc.target/powerpc/fold-vec-neg-ing.p7.c: Remove test file.

Typo in the file name here.

> +/* Altivec NEG functions.  */
> +BU_P8V_AV_1 (NEG_V2DI,      "neg_v2di",      CONST,  negv2di2)
> +BU_P8V_AV_1 (NEG_V4SI,      "neg_v4si",      CONST,  negv4si2)
> +BU_P8V_AV_1 (NEG_V8HI,      "neg_v8hi",      CONST,  negv8hi2)
> +BU_P8V_AV_1 (NEG_V16QI,     "neg_v16qi",     CONST,  negv16qi2)
> +BU_P8V_AV_1 (NEG_V4SF,      "neg_v4sf",      CONST,  negv4sf2)
> +BU_P8V_AV_1 (NEG_V2DF,      "neg_v2df",      CONST,  negv2df2)

The comment is misleading (these are only for p8 and later, not for all
AltiVec).

Okay for trunk with that fixed.  Does this need backporting to 7?

Thanks!


Segher

Reply via email to