On 02/20/2018 10:18 AM, Richard Sandiford wrote:
> r254302 tried to clean up find_widening_optab_handler_and_mode
> so that it really did only handle widening ops rather than
> simple single-mode ones.  But this PR shows that I'd fluffed
> the MODE_PARTIAL_INT handling.  It turns out that all four
> combinations of:
> 
>   {MODE_INT,MODE_PARTIAL_INT}->{MODE_INT,MODE_PARTIAL_INT}
> 
> are possible, and GET_MODE_WIDER_MODE for a MODE_PARTIAL_INT
> returns a MODE_INT (which makes sense in retrospect).
> 
> No test case since this is a build failure on affected targets.
> 
> Tested on aarch64-linux-gnu, x86_64-linux-gnu and powerpc64le-linux-gnu.
> Also tested by Jozef on msp430-elf (thanks).  OK to install?
> 
> Richard
> 
> 
> 2018-02-20  Richard Sandiford  <richard.sandif...@linaro.org>
> 
> gcc/
>       PR middle-end/84406
>       * optabs-query.c (find_widening_optab_handler_and_mode): If from_mode
>       is a scalar_int_mode, assert that to_mode is a scalar_int_mode with
>       greater precision.  If to_mode is a MODE_PARTIAL_INT, stop the
>       search at the associated MODE_INT.
THanks.  I went ahead and installed this.  My tester (which has a msp430
target) will pick this up on its next run.

jeff

Reply via email to