Hi Carl,

On Thu, Feb 22, 2018 at 07:41:10AM -0800, Carl Love wrote:
>       * gcc.target/powerpc/builtins-3.c: Move vec_neg builtin tests to
>       Power 8 test file.
>       * gcc.target/powerpc/builtins-3-p8.c: Add vec_neg builtin tests.
>       * gcc.target/powerpc/fold-vec-neg-char.c(dg-options): Add -mcpu=power8.
>       * gcc.target/powerpc/fold-vec-neg-floatdouble.c(dg-options): Add
>       -mcpu=power8.
>       * gcc.target/powerpc/fold-vec-neg-int.c(dg-options): Remove file.
>       * gcc.target/powerpc/fold-vec-neg-short.c(dg-options): Add
>       -mcpu=power8.

You should use a space before ( there.

> +     test_neg_char                             1 vspltisw, 1 vsububm
> +     test_neg_short                            1 vspltisw, 1 vsubuhm
> +     test_neg_int                              1 vspltisw, 1 vsubuwm

All these are p6 already (so needs just -maltivec).

> +     test_neg_float                            1 xvnegsp
> +     test_neg_float                            1 xvnegdp

... and these are p7 (so needs just -mvsx).  I don't understand why you
move them to a p8 file?  Or ah, this is because the builtin is not
defined before p8?  Okay for trunk if so :-)

Thanks,


Segher

Reply via email to