On Wed, 2018-02-14 at 23:36 +0100, FX wrote: > I can confirm that, with the attached revised patch, a bootstrap with > --enable-languages=c,c++,jit --enable-host-shared is successful on > macOS. > > FX
Looks good to me; thanks for fixing. Release managers: I'd like to apply FX's patch here: https://gcc.gnu.org/ml/gcc-patches/2018-02/msg00881/patch to trunk, to fix the build of jit on OS X, and to make it easier to fix it on Solaris. This involves touching gcc/configure.ac (and configure). I've successfully bootstrapped and regression-tested it on x86_64-pc- linux-gnu. FX reports above that it fixes the build on macOS, and Rainer has an (untested) patch on top of it that ought to fix the build on Solaris: https://gcc.gnu.org/ml/gcc-patches/2018-02/msg00835.html We're in stage 4, and the two bugs in question: PR jit/64089 ("libgccjit.so.0.0.1 linkage failure on darwin") https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64089 PR jit/84288 ("Support jit on Solaris") https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84288 aren't regressions. However, I believe this is a low-risk patch, and is mostly confined to jit (and those targets). Is it OK for trunk now, or does this need to wait until next stage 1? Thanks Dave
