I noticed that data-sym-pool.c fails on -O0 flags.
-O0 output :
-----------------cut----------------------
frob:
.frame $17,8,$31 # vars= 0, regs= 1/0, args= 0, gp= 0
.mask 0x00020000,0
.fmask 0x00000000,0
addiu $sp,-8
sd $17,0($sp)
move $17,$sp
lw $2,$L4
move $sp,$17
ld $17,0($sp)
addiu $sp,8
jr $31
.type __pool_frob_3, @object
__pool_frob_3:
.align 2
$L3:
.word __gnu_local_gp
$L4:
.word 305419896
.type __pend_frob_3, @function
__pend_frob_3:
.insn
.end frob
.size frob, .-frob
.ident "GCC: (gcc trunk r258495 mips64el o32 n32 n64) 8.0.1
20180313 (experimental)"
-------------end----------------------------------------------
Is it expected ? maybe we should add skip-if -O0 flags.
Paul Hua
On Thu, Nov 17, 2016 at 1:15 AM, Maciej W. Rozycki <[email protected]> wrote:
> On Tue, 15 Nov 2016, Matthew Fortune wrote:
>
>> I'm a little concerned the expected output tests may be fragile over
>> time but let's wait and see.
>
> Indeed, but I'd rather see false negatives than false positives or no
> coverage at all. And I hope the pieces of expected assembly quoted will
> help telling any false negatives and actual regressions apart very easily.
>
>> OK to commit.
>
> Applied now, thanks for your review.
>
> Maciej
