Hi Bin, On 16/03/18 11:42, Bin Cheng wrote:
Hi, This simple patch fixes test case failure for pr84682-2.c by returning false on wrong mode rtx in aarch64_classify_address, rather than assert.Bootstrap and test on aarch64. Is it OK? Thanks, bin 2018-03-16 Bin Cheng <bin.ch...@arm.com> * config/aarch64/aarch64.c (aarch64_classify_address): Return false on wrong mode rtx, rather than assert.
This looks ok to me in light of https://gcc.gnu.org/ml/gcc-patches/2018-03/msg00633.html This function is used to validate inline asm operands too, not just internally-generated addresses. Therefore all kinds of garbage must be rejected gracefully rather than ICEing. You'll need an approval from an AArch64 maintainer though. Thanks, Kyrill
